Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write up docs on caveats around nullable subtables with non-nullable fields #38

Open
spenczar opened this issue Aug 9, 2023 · 0 comments

Comments

@spenczar
Copy link
Collaborator

spenczar commented Aug 9, 2023

288e291, eae0389, and fa916b2 were three commits dealing with one tricky issue: what do we do when a Table has a nullable subtable column, but the subtable itself has non-nullable fields?

Those commits deal with this situation in a somewhat unsatisfactory way: they rewrite the subtable's schema to accept null values.

This has the unfortunate effect of breaking the expectations of the subtable. Now its columns could have null values.

This should be documented, and explained. There's no real good way around it currently, since the subtable is implemented in such a transparent way. It would be good to think about better solutions, like maybe using a validity bitmap for subtables, allowing for at least some sort of filtering to only look at valid rows of a subtable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant