Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithBroker(true) now fails at build time, not at runtime #4767

Merged
merged 19 commits into from
May 20, 2024

Conversation

bgavrilMS
Copy link
Member

@bgavrilMS bgavrilMS commented May 15, 2024

Fixes #4768

We received feedback that after removing net6-windows tfm, apps fail at runtime due to using old broker API. It would be better if they fail at build time.

@bgavrilMS bgavrilMS requested a review from a team as a code owner May 15, 2024 18:48
@bgavrilMS
Copy link
Member Author

Only some ADFS tests are failing, due to lab issue. Merging.

@bgavrilMS bgavrilMS merged commit 61a9fb3 into main May 20, 2024
4 of 6 checks passed
@bgavrilMS bgavrilMS deleted the bogavril/net6win_feedback branch May 20, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Non reported breaking change on 4.61.0
4 participants