Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot deploy if app dist folder or function project is in project root #823

Open
1 of 2 tasks
sinedied opened this issue Mar 28, 2024 · 0 comments
Open
1 of 2 tasks

Comments

@sinedied
Copy link
Member

sinedied commented Mar 28, 2024

Before filing this issue, please ensure you're using the latest CLI by running swa --version and comparing to the latest version on npm.

Are you accessing the CLI from the default port :4280 ?

  • No, I am using a different port number (--port) and accessing the CLI from that port
  • Yes, I am accessing the CLI from port :4280

Make sure you are accessing the URL printed in the console when running swa start!

ℹ️ NOTE: Make sure to enable debug logs when running any swa commands using --verbose=silly

Describe the bug
If I have a project with a static website at the root of the repo, and a function contained in an /api subfolder, I cannot deploy the function and get this error:

image

Note that the same error occur is the website is in a subfolder, and the API package.json at the root of the repo (maybe a more common scenario), see https://github.com/sinedied/swa-functions-root-bug/tree/api-root

To Reproduce

  1. Git clone this repo: https://github.com/sinedied/swa-functions-root-bug/
  2. Run swa deploy

Expected behavior
No errors.

Desktop (please complete the following information):

  • OS: MacOS
  • Version 14.4

Additional context
It seems that the problem is due to the StaticSiteClient creating zip file of the artifacts in the current folder. Using a different temp folder might solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant