Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYO Custom VNET #199

Open
Bryce-Soghigian opened this issue Mar 14, 2024 · 3 comments · Fixed by #238 · May be fixed by #326
Open

BYO Custom VNET #199

Bryce-Soghigian opened this issue Mar 14, 2024 · 3 comments · Fixed by #238 · May be fixed by #326
Assignees
@Bryce-Soghigian
Labels
area/nap Issues or PRs related to Node Auto Provisioning (NAP) area/networking Issues or PRs related to networking kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Bryce-Soghigian
Copy link
Contributor

Bryce-Soghigian commented Mar 14, 2024 •
edited

Tell us about your request

Today, karpenter doesn't support specifying a custom vnet. We should implement the basic functionality to allow users to specify a custom vnet in the AKS API, then propagate those settings and configurations to be used by karpenter.

Step one of this work would be to modify handleVNET. We should fetch the VNETSubnetID from the AKS Agentpool. If it is unset on the default systempool, then we should just use the standard VNET here.

This issue should solve the case of karpenter crashing when a custom vnetSubnetID is specifed on the managed cluster

Are you currently working around this issue?

No.

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@tallaxes tallaxes added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/nap Issues or PRs related to Node Auto Provisioning (NAP) area/networking Issues or PRs related to networking labels Mar 14, 2024
@tallaxes tallaxes mentioned this issue Mar 14, 2024
Open
@zhangchl007
Copy link

I encountered the same issue as well.

@Bryce-Soghigian Bryce-Soghigian self-assigned this Mar 14, 2024
@Bryce-Soghigian Bryce-Soghigian changed the title Custom VNET Support BYO Custom VNET Mar 29, 2024
@Bryce-Soghigian Bryce-Soghigian mentioned this issue Mar 29, 2024
Merged
3 tasks
@Bryce-Soghigian Bryce-Soghigian mentioned this issue Apr 16, 2024
Closed
@Bryce-Soghigian
Copy link
Contributor Author

Bryce-Soghigian commented Apr 16, 2024 •
edited

Going to keep this open until we have fully rolled out custom vnet support. We are working on cutting the release right now.

@Bryce-Soghigian Bryce-Soghigian linked a pull request May 6, 2024 that will close this issue
Open
3 tasks
@Bryce-Soghigian
Copy link
Contributor Author

The release has reached eastus. I tested today with the makefile commands posted in #326 to validate that bringing your own custom vnet works.

Note for NAP has one extra step for BYO vnet which is to assign an RBAC role the cluster needs(see #326).

Applying this role on existing clusters with the latest nap release should bring the karpenter pod out of crashloopbackoff and it will start provisioning nodes within 5 minutes of that role being applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bryce-Soghigian Bryce-Soghigian

Labels
area/nap Issues or PRs related to Node Auto Provisioning (NAP) area/networking Issues or PRs related to networking kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@zhangchl007 @tallaxes @Bryce-Soghigian