Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be an E2E to test if a node has sufficient permissions to pull an image from ACR #221

Open
comtalyst opened this issue Mar 20, 2024 · 1 comment
Assignees
Labels
area/e2e-testing Issues or PRs related to e2e testing area/provisioning Issues or PRs related to provisioning (instance provider) kind/proposal Issues or PRs related to proposals.

Comments

@comtalyst
Copy link
Collaborator

comtalyst commented Mar 20, 2024

Tell us about your request

There should be at least a suite of E2E (or equivalent) to check if the feature of ACR integration is valid.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

#197 is a gap in our E2E test coverage. In other words—the feature of ACR integration in general (https://learn.microsoft.com/en-us/azure/aks/cluster-container-registry-integration?tabs=azure-cli#attach-an-acr-to-an-existing-aks-cluster).
The root cause of the issue appears to be incorrect propagation of identities to the provisioning nodes. We could also expand the scope to other areas that depends on this too if there is an opportunity.

The assumption that the identities are propagated properly is also something that could be broken (e.g., refactoring identities propagation), thus check-in test suites would help catching such breaking changes.

Are you currently working around this issue?

No

Additional Context

See #197 and its associated PR.

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@comtalyst comtalyst added area/e2e-testing Issues or PRs related to e2e testing kind/proposal Issues or PRs related to proposals. area/provisioning Issues or PRs related to provisioning (instance provider) labels Mar 20, 2024
@Bryce-Soghigian
Copy link
Contributor

Bryce-Soghigian commented Apr 3, 2024

Seems easy enough to upload the pause image we use to the acr created with the cluster and use that image rather than an mcr pause image.

There is more testing we could do around image pull with features like artifact streaming that would require we upload images and enable streaming on them anyway that could make sense to do it there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e-testing Issues or PRs related to e2e testing area/provisioning Issues or PRs related to provisioning (instance provider) kind/proposal Issues or PRs related to proposals.
Projects
None yet
Development

No branches or pull requests

2 participants