Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UltraSSD when deploying VM that supports it #119

Open
rverma-dev opened this issue Jan 27, 2024 · 3 comments
Open

Enable UltraSSD when deploying VM that supports it #119

rverma-dev opened this issue Jan 27, 2024 · 3 comments
Labels
area/instance-types Issues or PRs related to instance types area/storage Issues or PRs related to storage kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rverma-dev
Copy link

Tell us about your request

Trying to enabled and use ultra-ssd for nodepool created by karpenter

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

converting below to Nodepool

az aks nodepool add --name tikv \
    --cluster-name  \
    --resource-group ${resourceGroup} \
    --node-vm-size ${nodeType} \
    --zones 1 2 3 \
    --aks-custom-headers EnableAzureDiskFileCSIDriver=true \
    --node-count 3 \
    --labels dedicated=tikv \
    --node-taints dedicated=tikv:NoSchedule \
    --enable-ultra-ssd

Are you currently working around this issue?

No

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@Bryce-Soghigian Bryce-Soghigian added area/storage Issues or PRs related to storage needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/instance-types Issues or PRs related to instance types labels Jan 28, 2024
@Bryce-Soghigian
Copy link
Contributor

Thanks for creating an issue!

Leaving some notes as Ultra SSD and my inital thoughts on how it conflicts with karpenter today(not to say we will never implement)

  1. Ultra disks can't be used as OS disks, they can only be created as empty data disks. Currently we only are creating the os disk in current karpenter implementation.
  2. Ultra Disks require zonal knowledge to know if its available. This introduces a new dimension to karpenter's requirements

We need to design and think through data disks and requirements being zonal aware.

@rverma-dev
Copy link
Author

Yeah the usecase is not for OS disks for sure. However I believe to start with we need to find a way to modify AdditionalCapabilities.UltraSSDEnabled = true.

@tallaxes
Copy link
Collaborator

tallaxes commented Jan 30, 2024

We should add enabling UltraSSD automatically when using VM SKU that supports it, in supported zone - we have this information from SKU API.

Not marking this as "good first issue" because it will likely require a bit of design around flowing extra settings into bootstrap (or making SKU capabilities overall accessible in bootstrap).

@tallaxes tallaxes added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 30, 2024
@tallaxes tallaxes changed the title How to enable ultra-ssd Enable UltraSSD when deploying VM that supports it Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/instance-types Issues or PRs related to instance types area/storage Issues or PRs related to storage kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants