Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[changelog] detect type change of model property #35514

Open
Tracked by #35515
msyyc opened this issue May 7, 2024 · 0 comments
Open
Tracked by #35515

[changelog] detect type change of model property #35514

msyyc opened this issue May 7, 2024 · 0 comments
Assignees
@msyyc
Labels
feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. Mgmt-EngSys Engineering System (Management Plane Specific)

Comments

@msyyc
Copy link
Member

msyyc commented May 7, 2024 •
edited

Python changelog can't detect breaking change about type change. For example:

"$ref": "../../stable/2019-10-01/policyStates.json#/definitions/PolicyEvaluationDetails" is changed to
"$ref": "#/definitions/CheckRestrictionEvaluationDetails" and changelog tool doesn't show the breaking: https://github.com/Azure/azure-rest-api-specs/pull/22789/checks?check_run_id=12642771856
@msyyc msyyc added Mgmt This issue is related to a management-plane library. Mgmt-EngSys Engineering System (Management Plane Specific) labels May 7, 2024
@msyyc msyyc self-assigned this May 7, 2024
@msyyc msyyc added the feature-request This issue requires a new behavior in the product in order be resolved. label May 7, 2024
This was referenced May 7, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msyyc msyyc

Labels
feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. Mgmt-EngSys Engineering System (Management Plane Specific)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msyyc