-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address comments from API review: **kwargs pass through; make keyword arguments keyword-only #34467
base: main
Are you sure you want to change the base?
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
mount_point: Optional[str] = None, | ||
mode: str = "ro_mount", | ||
debug: bool = False, | ||
persistent: bool = False, | ||
**_kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove kwargs - it needs to be supported publicly and passed down to the underlying generated layer.
It should just be renamed to remove the underscore prefix.
Same applies to the datastore operation below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding **kwargs
, and passing it to generated layer (updateDataMounts
).
Note that there is one thing special about data/datastore mount operation, different from other operations: it does not call exactly one operation in underlying generated layer.
- when
persistent=True
is callsupdateDataMounts
thengetCompute
, both in generated layer; - when
persistent=False
it does not call generated layer at all.
Hi @lizy14. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @lizy14. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
/reopen |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines