Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments from API review: **kwargs pass through; make keyword arguments keyword-only #34467

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lizy14
Copy link
Member

@lizy14 lizy14 commented Feb 27, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@lizy14 lizy14 changed the base branch from release/azure-ai-ml/1.14.0 to main February 28, 2024 07:19
mount_point: Optional[str] = None,
mode: str = "ro_mount",
debug: bool = False,
persistent: bool = False,
**_kwargs,
Copy link
Member

@annatisch annatisch Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove kwargs - it needs to be supported publicly and passed down to the underlying generated layer.
It should just be renamed to remove the underscore prefix.
Same applies to the datastore operation below.

Copy link
Member Author

@lizy14 lizy14 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding **kwargs, and passing it to generated layer (updateDataMounts).

Note that there is one thing special about data/datastore mount operation, different from other operations: it does not call exactly one operation in underlying generated layer.

  • when persistent=True is calls updateDataMounts then getCompute, both in generated layer;
  • when persistent=False it does not call generated layer at all.

@annatisch

@lizy14 lizy14 changed the title Address comments from API review: remove **_kwargs and make keyword arguments keyword-only Address comments from API review: **kwargs pass through; make keyword arguments keyword-only Feb 29, 2024
@lizy14 lizy14 requested a review from annatisch March 5, 2024 08:45
Copy link

Hi @lizy14. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 10, 2024
Copy link

Hi @lizy14. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this May 17, 2024
@lizy14
Copy link
Member Author

lizy14 commented Feb 5, 2025

/reopen

@github-actions github-actions bot reopened this Feb 5, 2025
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants