Azure.Monitor.OpenTelemetry.AspNetCore.Internals.AzureSdkCompat.AzureEventSourceLogForwarder double formats event messages

[christothes]

azure-sdk-for-net/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Internals/AzureSdkCompat/AzureEventSourceLogForwarder.cs

Line 70 in c4418cd

_listener ??= new AzureEventSourceListener((e, s) => LogEvent(e), EventLevel.Verbose);

calls LogEvent, but ignores the formatted string coming from the s parameter.

LogEvent then calls _formatMessage here:

azure-sdk-for-net/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Internals/AzureSdkCompat/AzureEventSourceLogForwarder.cs

Line 34 in c4418cd

logger.Log(MapLevel(eventData.Level), new EventId(eventData.EventId, eventData.EventName), new EventSourceEvent(eventData), null, _formatMessage);

which is defined as:

azure-sdk-for-net/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Internals/AzureSdkCompat/AzureEventSourceLogForwarder.cs

Line 64 in c4418cd

private static string FormatMessage(EventSourceEvent eventSourceEvent, Exception _) => eventSourceEvent.Format();

Then EventSource.Format() calls:

azure-sdk-for-net/sdk/core/Azure.Core/src/Shared/EventSourceEvent.cs

Line 58 in 2a0e020

return EventSourceEventFormatting.Format(EventData);

This seems to effectively calls EventSourceEventFormatting.Format twice.

(related to #43947 (comment))

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @rajkumar-rangaraj @reyang @TimothyMothra @vishweshbankwar.