Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All credentials have parameterless ctor #43962

Merged
merged 2 commits into from
May 15, 2024
Merged

All credentials have parameterless ctor #43962

merged 2 commits into from
May 15, 2024

Conversation

christothes
Copy link
Member

closes #43959

@christothes christothes requested review from schaabs and a team as code owners May 9, 2024 20:48
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Identity

scottaddie
scottaddie reviewed May 10, 2024
View reviewed changes
Copy link
Member

@scottaddie scottaddie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this protected, parameterless ctor also be added to credential types like Workload Identity and VS?

sdk/identity/Azure.Identity/tests/AzurePipelinesCredentialTests.cs Show resolved Hide resolved
@christothes christothes merged commit 9637250 into Azure:main May 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaddie scottaddie scottaddie left review comments

@jsquire jsquire jsquire approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all credential types mockable
4 participants
@christothes @azure-sdk @jsquire @scottaddie