-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default hostname changes (azurewebsites.net) #10090
Comments
Work for this is in progress. Finalizing validation. |
Please find notes from my investigation below.
HostName provider has hardcoded value for linux dedicated however the code path that hardcodes the value does not activate. This is because WEBSITE_HOSTNAME is available on Linux Dedicated. We simply need to remove the coding as it is dead code anyway. Remove the hardcoded string used to create hostname for Linux dedicated Remove the hardcoded string used to create hostname for Linux dedicated.
The host id generated here for region specific host name works fine. Any change here would be breaking for existing customers in sovereign and air gapped clouds. We can try to make the change here so that it only applies to public cloud.
Have validated the hostname for all SKU's. As mentioned above Additionally have filed the item below Evalute if WEBSITE_DEFAULT_HOSTNAME should be used for setting hostname |
The App Service platform is moving to a strategy where the default hostname for a site will vary regionally. This means that code can't simply assume "azurewebsites.net".
New default hostname format:
siteName-<dnlHash>.<region>.azurewebsites.net
SCM site will have this format:
siteName-<dnlHash>.scm.<region>.azurewebsites.net
There are several known places in the host currently where we're using this string literal. We'll need to review all these and make changes as required. These include:
The text was updated successfully, but these errors were encountered: