Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-11-01 API version for Azure Managed HSM #30756

Open
Cherrett opened this issue Feb 4, 2025 · 3 comments
Open

2024-11-01 API version for Azure Managed HSM #30756

Cherrett opened this issue Feb 4, 2025 · 3 comments
Assignees
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team feature-request KeyVault az keyvault Possible-Solution Similar-Issue
Milestone

Comments

@Cherrett
Copy link
Member

Cherrett commented Feb 4, 2025

Related command

I am a part of the Azure Managed HSM team. When creating a new Managed HSM resource using az keyvault create, the SKU defaults to the B family, irrespective of the SKU name specified. This is not correct since we have certain SKUs in the C family.

Source Code

Is your feature request related to a problem? Please describe.

az keyvault create --hsm-name "test" --resource-group "test" --sku Custom_C42

Describe the solution you'd like

The new SKUs are included in the Microsoft.KeyVault 2024-11-01 API version. Azure CLI should use this API version.

Additional context

These are all of the valid Managed HSM SKUs:

B SKU family: Standard_B1, Custom_B32, Custom_B6
C SKU family: Custom_C42, Custom_C10

For Custom_C42 and Custom_C10, the SKU family passed to ARM should be C instead of B.

This can be determined by checking the letter following the underscore in the SKU name.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 4, 2025

Thank you for opening this issue, we will look into it.

@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot KeyVault az keyvault labels Feb 4, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Here are some similar issues that might help you. Please check if they can solve your problem.


Possible solution (Extracted from existing issue, might be incorrect; please verify carefully)

Azure CLI is using 2023-07-01 API version for MHSM operations and from the swagger there're only skus for B family: Standard_B1,Custom_B32,Custom_B6. We are not aware of any C family. If there's feature added, can you pls update swagger to generate SDK new version and then file a feature request for CLI team?

Reference:

@yonzhan yonzhan added this to the Backlog milestone Feb 4, 2025
@yonzhan yonzhan added feature-request and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 4, 2025
@evelyn-ys
Copy link
Member

evelyn-ys commented Feb 5, 2025

@Cherrett Pls make sure that the new API version has been added in swagger repo and the related Python SDK has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team feature-request KeyVault az keyvault Possible-Solution Similar-Issue
Projects
None yet
Development

No branches or pull requests

3 participants