Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG ZeroWidthConverter not included in pyrit.prompt_converter 's __init__.py #843

Open
romanlutz opened this issue Mar 30, 2025 · 5 comments
Open

BUG ZeroWidthConverter not included in pyrit.prompt_converter 's __init__.py #843

romanlutz opened this issue Mar 30, 2025 · 5 comments
Assignees
@AnnaRevutsky
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@romanlutz
Copy link
Contributor

Describe the bug

This must have been an oversight. Currently, I have to write

from pyrit.prompt_converter.zero_width_converter import ZeroWidthConverter

to import the converter, but I want to do

from pyrit.prompt_converter import ZeroWidthConverter

This means we have to include it in the corresponding init.py file.
@romanlutz romanlutz added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Mar 30, 2025
@AnnaRevutsky
Copy link

Hello! May I work on this bug?

@romanlutz
Copy link
Contributor Author

Absolutely! Reach out if you have questions.

@paulinek13
Copy link
Contributor

paulinek13 commented Mar 31, 2025 •
edited
Loading

Hi!
@AnnaRevutsky
Actually, there's one more missing - the InsertPunctuationConverter. I've noticed this while working on something else, so I'm just letting you know 😉

@AnnaRevutsky AnnaRevutsky mentioned this issue Mar 31, 2025
Open
@romanlutz
Copy link
Contributor Author

Nice catch! Actually, I just noticed we forgot to add all the converters to api.rst as well. @AnnaRevutsky could you add them there as well? We need some kind of auto-check for that... (which isn't in scope for this issue)

@AnnaRevutsky
Copy link

Sure, no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnnaRevutsky AnnaRevutsky

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romanlutz @AnnaRevutsky @paulinek13