Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets leak fix (do not merge) #400

Closed
wants to merge 17 commits into from

Conversation

dfberry
Copy link
Contributor

@dfberry dfberry commented Nov 7, 2023

Fixes #386: by moving off v3 to v4 for api - used git mv instead of mv

Fixes #350

  1. remove 3 secrets from Azure Function environment so they don't show up in log,
  2. remove 3 seconds from infra output,
  3. Add 3 secrets with correct names to Key Vault from infra
  4. read Key Vault in ./secrets for db restore, wrapper bash script to read kv and restore db
  5. don't need to do anything for API code because it was already reading Key Vault as part of config

With this PR, both blog and portal work again when deployed.

@dfberry dfberry changed the title Secrets leak fix Secrets leak fix (Review but do not merge) Nov 7, 2023
@dfberry dfberry changed the title Secrets leak fix (Review but do not merge) Secrets leak fix (do not merge) Nov 10, 2023
@dfberry dfberry closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] (API): Move plain text secrets out of env file and into Key Vault [Chore] npm install issues
1 participant