Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing PlotStyle in a loop can raise matplotlib latex errors #69

Open
prismv opened this issue Sep 13, 2024 · 2 comments
Open

Changing PlotStyle in a loop can raise matplotlib latex errors #69

prismv opened this issue Sep 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@prismv
Copy link

prismv commented Sep 13, 2024

See MR Axect/Peroxide_Gallery#1 for code that creates this bug - as discussed in comments.

MR Axect/Peroxide_Gallery#2 should provide a working example based on improved upstream functions.

@Axect
Copy link
Owner

Axect commented Sep 14, 2024

Hey there, thanks for jumping on this so quickly! I really appreciate your enthusiasm. I just wanted to clear up a couple of things:

  1. The bug we found is actually in the Peroxide library itself, not in Peroxide_Gallery. When I mentioned opening an issue, I meant in the main Peroxide repo. That way, we can tackle the root of the problem.

  2. Would you mind if I move this issue over to the Peroxide repo? It'll help us keep track of things better.

  3. Once we fix this in Peroxide, we can circle back to your PR in Peroxide_Gallery. We should be able to uncomment your code and get it working smoothly.

  4. It's great that you've already submitted a PR to Peroxide_Gallery - nice initiative! We'll just need to put it on hold until we sort out the Peroxide issue. After that, we can review it and hopefully merge it in with any tweaks needed.

What do you think about handling it this way? I think it'll let us solve the main issue first, then bring your contribution into Peroxide_Gallery smoothly.

If you're okay with this, I can move the issue to the Peroxide repo now. Let me know what you think.

@prismv
Copy link
Author

prismv commented Sep 14, 2024

No, I don't mind if you shift this issue to the library repro. All statements are fine for me.

@Axect Axect transferred this issue from Axect/Peroxide_Gallery Sep 14, 2024
@Axect Axect self-assigned this Sep 14, 2024
@Axect Axect added the bug Something isn't working label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants