Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlapWindowPlugin forbids multiple provides #919

Open
dachengx opened this issue Nov 3, 2024 · 0 comments
Open

OverlapWindowPlugin forbids multiple provides #919

dachengx opened this issue Nov 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dachengx
Copy link
Collaborator

dachengx commented Nov 3, 2024

strax/strax/plugins/overlap_window_plugin.py

Line 54 in 1e0b6d8

_, result = result.split(t=self.sent_until, allow_early_split=False)
implies that OverlapWindowPlugin does not support multiple provides. But we did not raise a NotImplementedError. This should be fixed.
@dachengx dachengx added the enhancement New feature or request label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dachengx