Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete selected links using the delete key #6

Open
mkrasnitski opened this issue Nov 17, 2021 · 1 comment
Open

Delete selected links using the delete key #6

mkrasnitski opened this issue Nov 17, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mkrasnitski
Copy link
Contributor

Links can currently be selected but no action can be taken within that context. I use Alt as my mod key in i3wm, so can't currently use the UI to delete links between nodes, as alt-dragging controls the window position and size for me. I think letting links be deleted by selecting them and hitting Delete would work well. By the way, what controls these keybinds? Do they come from egui_nodes are from some other crate?

@Ax9D
Copy link
Owner

Ax9D commented Nov 18, 2021

Yes I agree, context based deletion would be a good addition.
pw-viz uses a slightly modified fork of egui_nodes for drawing nodes, which doesn't provide such functionality yet, but I think this can be added by creating a new ClickInteractionType::LinkDeleted
and handling it inside click_interaction_update(...) defined here

The detach keybind is defined here

@Ax9D Ax9D added enhancement New feature or request help wanted Extra attention is needed labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants