Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG] on_action function is not valid after downloading in case of a multi-pages apllication #2450

Open
1 of 7 tasks
dataxcount opened this issue Feb 17, 2025 · 1 comment
Labels
🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible 🔒 Staff only Can only be assigned to the Taipy R&D team

Comments

@dataxcount
Copy link

dataxcount commented Feb 17, 2025

What went wrong? 🤔

This provided example https://github.com/Avaiga/taipy/blob/release/4.0/doc/gui/examples/controls/file_download_dynamic_temp_file.py works well in this simple case : clean_up function (on_action parameter of download function) is called and temporary file is deleted.
But in my case of a multi-pages application, on_action function is not properly called since it leads here https://github.com/Avaiga/taipy/blob/develop/taipy/gui/gui.py#1630 ( _warn(f"on_action(): '{action}' is not a valid function.") )

Expected Behavior

In any cases of application (espacially in multi-pages application with each page in separate module),
the on_action parameter of download function must allow to delete properly the temporary file required for dynamic file_download functionnalilty.

Additional Context

Acceptance Criteria

  • A unit test reproducing the bug is added.
  • Any new code is covered by a unit tested.
  • Check code coverage is at least 90%.
  • The bug reporter validated the fix.
  • Related issue(s) in taipy-doc are created for documentation and Release Notes are updated.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@dataxcount dataxcount added the 💥Malfunction Addresses an identified problem. label Feb 17, 2025
@jrobinAV jrobinAV added 🟥 Priority: Critical Must be addressed as soon as possible 🟧 Priority: High Must be addressed as soon 🔒 Staff only Can only be assigned to the Taipy R&D team and removed 🟧 Priority: High Must be addressed as soon labels Feb 21, 2025
@AlexandreSajus
Copy link
Contributor

Thanks for the bug report. Could you please provide a piece of code that reproduces your issue so we can take a look?

@jrobinAV jrobinAV added the 🖰 GUI Related to GUI label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible 🔒 Staff only Can only be assigned to the Taipy R&D team
Projects
None yet
Development

No branches or pull requests

3 participants