Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering from course page does not redirect back to the course #2768

Open
danjjohnson opened this issue Aug 12, 2019 · 2 comments · May be fixed by #2845
Open

Registering from course page does not redirect back to the course #2768

danjjohnson opened this issue Aug 12, 2019 · 2 comments · May be fixed by #2845
Labels
[Pri] Normal Can wait for the next release [Type] Enhancement

Comments

@danjjohnson
Copy link
Contributor

Steps to Reproduce

  1. Enable 'Anyone can register' in Settings > General, and 'Access Permissions' in Sensei LMS > Settings.
  2. View a course page as a logged out user.
  3. Click the Register button and complete the registration form

What I Expected

I would see some kind of registration success message and be redirected back to the course page.

What Happened Instead

I was redirected to the home page and saw no evidence that the registration was successful.

PHP / WordPress / Sensei version

7.3.7 / 5.2.2 / 2.1.2

Browser / OS version

Any browser

Context / Source

Reported in 2251592-zen
@danjjohnson danjjohnson added [Type] Enhancement [Pri] Normal Can wait for the next release labels Aug 12, 2019
@donnapep donnapep added [Pri] Low Cosmetic issue, low impact, easy workaround [Status] Accepted and removed [Pri] Normal Can wait for the next release labels Sep 9, 2019
@donnapep
Copy link
Collaborator

donnapep commented Sep 9, 2019 •
edited
Loading

We should redirect back to the course page after the user registers. I don't think a success message is necessary though, as the "Start Taking this Course" button will be visible to enable the user to enrol in the course.

@donnapep donnapep changed the title Registering from course page does not return you to the course. Registering from course page does not redirect back to the course Sep 9, 2019
@donnapep donnapep added [Pri] Normal Can wait for the next release and removed [Pri] Low Cosmetic issue, low impact, easy workaround labels Oct 19, 2019
@donnapep donnapep added this to the 2.3.0 milestone Nov 1, 2019
@JuanchoPestana JuanchoPestana linked a pull request Jan 17, 2020 that will close this issue
Open
@JuanchoPestana
Copy link
Contributor

Hey Donna and Dan! In the PR description I explain what my findings were regarding this issue... Please let me know your thoughts on this approach, if you'd like me to try a different one (in case I was wrong or you'd prefer something else), or if there's anything else I can do to help!

Oh, and btw Donna, when executing the code sniffer (with the standards that came with the plugin) I realized that there are some warnings and errors regarding comment styling, naming conventions, deprecated parameters, etc... I'm not sure if they're being ignored on purpose, or that you have a thousand more critical things on your table!... In case it's the latter, would you like me to spend some time fixing all of those; or adding the phpcs ignore comment in case the "error" should be ignored? Would that be helpful? (And I wasn't sure if this is the right place to ask this so I'm sorry if it isn't!)

@donnapep donnapep removed this from the 3.1.0 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Pri] Normal Can wait for the next release [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/issue 2768 JuanchoPestana/sensei
3 participants
@donnapep @danjjohnson @JuanchoPestana