Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: use a DOM-aware library to manipulate SVGs #123

Open
folletto opened this issue Dec 4, 2015 · 0 comments
Open

Build: use a DOM-aware library to manipulate SVGs #123

folletto opened this issue Dec 4, 2015 · 0 comments

Comments

@folletto
Copy link
Contributor

folletto commented Dec 4, 2015

Following from the discussion in #122, would be better if we were able to replace direct string manipulation with XML (SVG) aware libraries, such as cheerio. This would make the code more reliable in the long term.

Example of direct string manipulation:

    fileContent = fileContent.slice( 0, -6 ) +
        '<rect x="0" style="fill:none;" width="24" height="24"/>' +
        fileContent.slice( -6 );
@folletto folletto changed the title Grunt: use a DOM-aware library to manipulate SVGs Build: use a DOM-aware library to manipulate SVGs Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant