Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spacing unit with map #55

Open
ArmorDarks opened this issue Apr 29, 2016 · 1 comment
Open

Replace spacing unit with map #55

ArmorDarks opened this issue Apr 29, 2016 · 1 comment
Milestone

Comments

@ArmorDarks
Copy link
Owner

Instead of

$ekzo-spacing-unit: $ekzo-line-height !default;

We can allow to do

$ekzo-spacing-units: (
  base: $ekzo-line-height,
  blog: $ekzo-blog-line-height
) !default;

Yet, all benefits of such change are unclear yet.

@ArmorDarks
Copy link
Owner Author

ArmorDarks commented Jun 13, 2016

I'm not sure that we need this, because it's anyway impossible to generate anything automatically based on it. So, probably it has no difference with just declaring

$ekzo-spacing-unit: $ekzo-line-height !default;
$blog-spacing-unit: $blog-line-height !default;

We could generate margins and paddings based on it, but it's way too opinionated.

@ArmorDarks ArmorDarks modified the milestone: backlog Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant