Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace line-height with ratios #54

Open
ArmorDarks opened this issue Apr 29, 2016 · 1 comment
Open

Replace line-height with ratios #54

ArmorDarks opened this issue Apr 29, 2016 · 1 comment
Milestone

Comments

@ArmorDarks
Copy link
Owner

This one is tricky.

We might allow to specify ration instead of px value for base line-heights:

Instead of

$ekzo-line-height-ratios: (
  base: ekzo-font-size(base) * 1.5,
  blog: ekzo-font-size(text, blog) * 1.5,
) !default;

Do

$ekzo-line-height-ratios: (
  base: 1.5,
  blog: 1.5,
) !default;

The issue here is that it seems to be more limiting... Need to think about it better.

@ArmorDarks
Copy link
Owner Author

So far it seems to be undesired at least for base line-heights, since it will affect font-sizes, set with % — they will break out of grid with line-height set in ratio.

@ArmorDarks ArmorDarks modified the milestone: backlog Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant