nx-X11/programs/Xserver/hw/nxagent/Events.c: Add pWin NULL point check before operating on it.

sunweaver · sunweaver · commit f9cbd37d11a8 · 2024-11-22T22:09:52.000+01:00
diff --git a/nx-X11/programs/Xserver/hw/nxagent/Events.c b/nx-X11/programs/Xserver/hw/nxagent/Events.c
@@ -4512,7 +4512,7 @@ Bool ForwardClientMessage(ClientPtr client, xSendEventReq *stuff)
     WindowPtr pWin = (WindowPtr)SecurityLookupWindow(stuff->destination, client,
                                                      DixReadAccess);
 
-    if (stuff->event.u.clientMessage.u.l.type == netwmstate || stuff->event.u.clientMessage.u.l.type == wmchangestate)
+    if (pWin && (stuff->event.u.clientMessage.u.l.type == netwmstate || stuff->event.u.clientMessage.u.l.type == wmchangestate))
     {
         if (pWin->drawable.id == pWin->drawable.pScreen->root->drawable.id)
         {

Original file line number	Diff line number	Diff line change
`@@ -4512,7 +4512,7 @@ Bool ForwardClientMessage(ClientPtr client, xSendEventReq *stuff)`
`4512`	`4512`	`WindowPtr pWin = (WindowPtr)SecurityLookupWindow(stuff->destination, client,`
`4513`	`4513`	`DixReadAccess);`
`4514`	`4514`
`4515`		`- if (stuff->event.u.clientMessage.u.l.type == netwmstate \|\| stuff->event.u.clientMessage.u.l.type == wmchangestate)`
	`4515`	`+ if (pWin && (stuff->event.u.clientMessage.u.l.type == netwmstate \|\| stuff->event.u.clientMessage.u.l.type == wmchangestate))`
`4516`	`4516`	`{`
`4517`	`4517`	`if (pWin->drawable.id == pWin->drawable.pScreen->root->drawable.id)`
`4518`	`4518`	`{`