From 092c07d119db7d2119b00acf576c8dfdc08e8ba8 Mon Sep 17 00:00:00 2001
From: Viktor Szakats <commit@vsz.me>
Date: Tue, 2 Jul 2024 10:41:35 +0200
Subject: [PATCH] winbuild: MS-DOS batch tidy-ups

- prefer `.bat` extension over `.cmd` for MS-DOS batch, which also
  avoids confusion with OS/400 `.cmd` files.
- cleanup `echo` quotes, drop them consistently.
- delete empty output line from one of the error branches.
- prefer lowercase commands like the rest of MS-DOS batches.
- delete a contraction.
- drop backticks from error message.
- use `nmake.exe` consistently.
- use equal/not-equal operator style consistently.
- inline a single-line `if` branch.
- delete exceptions and rules dealing with Windows `.cmd` extension.

Closes #14084
---
 .gitattributes                            |  3 +--
 .github/scripts/spacecheck.pl             |  4 ++--
 Makefile.am                               |  2 +-
 packages/OS400/.gitattributes             |  6 ------
 winbuild/{makedebug.cmd => makedebug.bat} | 13 +++++--------
 5 files changed, 9 insertions(+), 19 deletions(-)
 delete mode 100644 packages/OS400/.gitattributes
 rename winbuild/{makedebug.cmd => makedebug.bat} (81%)

diff --git a/.gitattributes b/.gitattributes
index d4f08a9e589b..41a5aff8dcbc 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -10,7 +10,6 @@ configure.ac eol=lf
 *.sh eol=lf
 *.[ch] whitespace=tab-in-indent
 
-# Batch files (bat,cmd) must be run with CRLF line endings.
+# Batch files must be run with CRLF line endings.
 # Refer to https://github.com/curl/curl/pull/6442
 *.bat text eol=crlf
-*.cmd text eol=crlf
diff --git a/.github/scripts/spacecheck.pl b/.github/scripts/spacecheck.pl
index 36847730f564..b2473b154414 100755
--- a/.github/scripts/spacecheck.pl
+++ b/.github/scripts/spacecheck.pl
@@ -30,7 +30,7 @@
     "^m4/zz40-xc-ovr.m4",
     "Makefile\\.[a-z]+\$",
     "/mkfile",
-    "\\.(bat|cmd|sln|vc)\$",
+    "\\.(bat|sln|vc)\$",
     "^tests/certs/.+\\.der\$",
     "^tests/data/test",
 );
@@ -43,7 +43,7 @@
 
 my @need_crlf = (
     "\\.(bat|sln)\$",
-    "^winbuild/.+\\.(cmd|md)\$",
+    "^winbuild/.+\\.md\$",
 );
 
 my @space_at_eol = (
diff --git a/Makefile.am b/Makefile.am
index ad8651c77c86..6d604ea89966 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -62,7 +62,7 @@ VC_DIST = projects/README.md                           \
  projects/wolfssl_override.props
 
 WINBUILD_DIST = winbuild/README.md winbuild/gen_resp_file.bat \
- winbuild/MakefileBuild.vc winbuild/Makefile.vc winbuild/makedebug.cmd
+ winbuild/MakefileBuild.vc winbuild/Makefile.vc winbuild/makedebug.bat
 
 PLAN9_DIST = plan9/include/mkfile \
  plan9/include/mkfile             \
diff --git a/packages/OS400/.gitattributes b/packages/OS400/.gitattributes
deleted file mode 100644
index e9b8201b5ec9..000000000000
--- a/packages/OS400/.gitattributes
+++ /dev/null
@@ -1,6 +0,0 @@
-# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
-#
-# SPDX-License-Identifier: curl
-
-# OS400 .cmd files are not windows scripts.
-*.cmd text eol=auto
diff --git a/winbuild/makedebug.cmd b/winbuild/makedebug.bat
similarity index 81%
rename from winbuild/makedebug.cmd
rename to winbuild/makedebug.bat
index 3f523c82f92f..e86e668ca0fb 100644
--- a/winbuild/makedebug.cmd
+++ b/winbuild/makedebug.bat
@@ -25,12 +25,9 @@ rem ***************************************************************************
 
 where.exe nmake.exe >nul 2>&1
 
-IF %ERRORLEVEL% == 1 (
-  ECHO Error: Can't find `nmake.exe` - be sure to run this script from within a Developer Command-Prompt
-  ECHO.
-) ELSE (
-  nmake /f Makefile.vc mode=static DEBUG=yes GEN_PDB=yes
-  IF %ERRORLEVEL% NEQ 0 (
-    ECHO "Error: Build Failed"
-  )
+if %ERRORLEVEL% EQU 1 (
+  echo Error: Cannot find nmake.exe - be sure to run this script from within a Developer Command-Prompt
+) else (
+  nmake.exe /f Makefile.vc mode=static DEBUG=yes GEN_PDB=yes
+  if %ERRORLEVEL% NEQ 0 echo Error: Build Failed
 )