Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config/setting or any other way to reduce Planes sound volume #6440

Open
rehv opened this issue Jul 15, 2022 · 2 comments · May be fixed by #7437
Open

Add config/setting or any other way to reduce Planes sound volume #6440

rehv opened this issue Jul 15, 2022 · 2 comments · May be fixed by #7437
Labels
enhancement An enhancement for an existing feature good-first-issue Issues that may be good for new contributors

Comments

@rehv
Copy link

rehv commented Jul 15, 2022

Describe the feature

As Title says, it would be really nice if there was a way to reduce the volume or even mute the sounds of Annihilation/Formation Planes, either a config/setting or other ways, e.g. an added recipe with wool to muffle them.

Reasons why it should be considered

Using these blocks in a large scale increase their volume to the point where it can be very annoying, specially for those like myself with an ear condition. I have a simple cobblestone generator (10 planes) and unless I'm very far from my base I can hear the really loud thumping every second, to the point I had to lower my block volume in minecraft to 5% (and I still hear it).

Additional details

No response
@Technici4n Technici4n added the enhancement An enhancement for an existing feature label Sep 5, 2022
@Technici4n Technici4n added this to the 1.19.4 milestone Mar 2, 2023
@Technici4n Technici4n added the good-first-issue Issues that may be good for new contributors label Mar 27, 2023
@Technici4n Technici4n removed this from the 1.19.4 - 1.20 milestone May 6, 2023
@floridaman
Copy link
Contributor

@Technici4n do you have any preferences on the requirements for this enhancement? Just a configuration option? Or some kind of muffle upgrade to the formation/annihilation plane?

Notes:

  1. It looks like item formation.annihilation is already silent, the sound only happens when the formation plane is in "block placement" mode.
  2. Do any other items in AE2 make noise? Should these also be configurable? Should there be a global "ae2 machine sounds level"?

Upgrade Option

  1. Determine method for muting/limiting range of formation/annihilation sounds.
  2. Create muffle upgrade to implement mute functionality
  3. Add upgrade interface to annihilation plane
  4. Documentation would also need to be updated everywhere.

Config Option

  1. Update config to accept new plane sound range option
  2. Determine method for muting/limiting range of formation/annihilation sounds.

Would you like me to pursue implementing this feature and if so what is the preferred option?

@Technici4n
Copy link
Member

Thanks for having a look. I was thinking that a float config option between 0 and 1 to set the volume of the planes would be enough.

Definitely no muffler upgrade: I don't like that mechanic in other mods, and we'd have to add a GUI just for that.

@floridaman floridaman linked a pull request Oct 9, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement for an existing feature good-first-issue Issues that may be good for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plane sound config floridaman/Applied-Energistics-2
3 participants
@rehv @floridaman @Technici4n