Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 3.7 Automatic Updates #3

Open
meloniq opened this issue Nov 21, 2014 · 5 comments
Open

WP 3.7 Automatic Updates #3

meloniq opened this issue Nov 21, 2014 · 5 comments

Comments

@meloniq
Copy link
Member

meloniq commented Nov 21, 2014

Digg on how it behaves with our products... Are they automatically updated to next minor version if available?! If so, what potential problems it may cause?! If not, how to enable it for our products?!

@meloniq meloniq added this to the Future Release milestone Nov 21, 2014
@meloniq meloniq added the bug label Nov 26, 2014
@meloniq
Copy link
Member Author

meloniq commented Nov 26, 2014

By default automatic updates for plugins and themes are disabled.

Can be enabled by adding filters:

add_filter( 'auto_update_plugin', '__return_true' );
add_filter( 'auto_update_theme', '__return_true' );

When auto updates enabled, our themes/plugins being omitted, and not updated.

Also, during auto update, our themes/plugins can be replaced to wrong one (with that same name) from WP.org

@cowgill
Copy link
Member

cowgill commented Aug 11, 2016

I think this is backwards now. Auto updates are enabled by default and you can disable them if you like.

So if a customer disables plugin auto updates, it should also disable our plugin updates.

@meloniq
Copy link
Member Author

meloniq commented Aug 23, 2016

@cowgill per my comment above, it seems like our 'Updater' plugin not being loaded during the autoupdate process, and as result:

  • our themes/plugins being omitted, and not updated
  • our themes/plugins NOT being protected, and can be replaced to wrong one (with that same name) from WP.org

@cowgill
Copy link
Member

cowgill commented Aug 24, 2016

@meloniq okay, can you provide a patch to enable this?

@meloniq
Copy link
Member Author

meloniq commented Aug 24, 2016

I did a quick look at the ET Updater, and they seems to be hooking into pre_set_site_transient_update_themes and pre_set_site_transient_update_plugins filters to check for updates, and into site_transient_update_themes and site_transient_update_plugins to populate updates check response...

I'll make some tests soon, and look closer on how it works and how we can handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants