Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxNativeAdLoaderImpl's Revenue Listener Causing Memory Leak #746

Open
ipena-spigot opened this issue Nov 6, 2024 · 2 comments
Open

MaxNativeAdLoaderImpl's Revenue Listener Causing Memory Leak #746

ipena-spigot opened this issue Nov 6, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ipena-spigot
Copy link

MAX SDK Version

13.0.1

Device/Platform Info

Pixel 4 XL - Android 13

Current Behavior

When loading an Ad for a particular AdUnit and selecting a specific network, MaxDebuggerAdUnitDetailActivity gets leaked

This makes it difficult to look into a different Ad-related memory leak

Expected Behavior

Resources / references should be released such that no memory leaks occur

How to Reproduce

  • Max Mediation Debugger
  • Ads
  • View Ad Units
  • Select an Ad where the Format is Native
  • Bidders
  • AppLovin
  • Load
  • Close Ad after it shows
  • Close Activity
  • Check for memory leak with Android Studio profiler***

Steps for: Check for memory leak with Android Studio***

  • In Android Studio
  • Profiler
  • Analyze Memory Usage
  • Start profiler task
  • Click on detected 2 Leaks
  • MaxDebuggerAdUnitDetailActivity
  • In the Instance tab: MaxDebuggerAdUnitDetailActivity
  • References tab
  • Show nearest GC root only
  • Expand non referent in WeakReference references

Reproducible in the demo app?

Yes

Additional Info

  • The memory leak doesn't seem to happen if you don't select a specific network in the Bidders / Waterfall section
  • The memory leak happened when selecting other bidders too
  • Seems as though MaxNativeAdLoaderImpl is holding on to a reference to revenueListener, which points to MaxDebuggerAdUnitDetailActivity

Screenshot 2024-11-05 at 11 45 44 AM

@ipena-spigot ipena-spigot added the bug Something isn't working label Nov 6, 2024
@mattn02 mattn02 added the in progress This is currently being worked on label Nov 18, 2024
@mattn02
Copy link
Contributor

mattn02 commented Nov 26, 2024

Hey @ipena-spigot - thanks for bringing this memory leak up to our attention! We have identified the issue and the fix will be live in our next SDK update. We will notify you in this thread once it has been released.

@mattn02 mattn02 removed the in progress This is currently being worked on label Nov 26, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This isue has been inactive label Dec 27, 2024
@mattn02 mattn02 removed the stale This isue has been inactive label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants