Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppLovinMAX.getAdaptiveBannerHeightForWidth returns wrong values #277

Open
centy opened this issue Nov 22, 2024 · 8 comments
Open

AppLovinMAX.getAdaptiveBannerHeightForWidth returns wrong values #277

centy opened this issue Nov 22, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@centy
Copy link

centy commented Nov 22, 2024

MAX Plugin Version

4.0.2

Flutter Version

3.24.5

Device/Platform Info

Android

Current Behavior

Returned value is incorrect, on some devices is do small on some to big.

Expected Behavior

Get correct value

How to Reproduce

final media = MediaQuery.of(context);
AppLovinMAX.getAdaptiveBannerHeightForWidth(media.size.width)

Reproducible in the demo app?

Not Tested

Additional Info

No response

@centy centy added the bug Something isn't working label Nov 22, 2024
@alhiwatan
Copy link
Collaborator

@centy, the height returned by the AppLovinMAX.getAdaptiveBannerHeightForWidth() function is designed to vary based on the device and the provided ad width. Internally, the function calculates the value dynamically to adapt to different screen sizes and densities.
If the height you receive appears unusually larger or smaller than the height of the current ad, this behavior is expected due to the adaptive nature of the function. However, if the discrepancy seems significant or impacts the user experience, please share additional details.

@centy
Copy link
Author

centy commented Nov 26, 2024

image
Check image, function returns not enough space. Google has its own way to get size of banner. Why you can ust that?

@alhiwatan
Copy link
Collaborator

@centy, thank you for pointing this out. After further investigation, we found that our Flutter plugin does not currently support adaptive banners, either programmatically or via native methods. However, the Android implementation inadvertently enabled adaptive banners in native methods.

We sincerely apologize for any confusion this may have caused. The issue has been addressed, and we’ve released version 4.1.1 to ensure consistent behavior.

@ycv005
Copy link

ycv005 commented Dec 17, 2024

@alhiwatan
any reason why you/your team has remove adaptive_banner ? I am currently using it.

@thomasmso
Copy link
Member

@ycv005 - we simply have not built robust support for adaptive banners into Flutter plugin yet. @alhiwatan is working on it.

@ycv005
Copy link

ycv005 commented Dec 17, 2024

@thomasmso Thank for the quick reply. If i am requesting adaptive ads then will it crash my app ? or deliever adaptive ads sometime and sometime normal banner ads ?

@alhiwatan
Copy link
Collaborator

@ycv005, it won't crash your app, but adaptive banners may not be correctly displayed.

@alhiwatan
Copy link
Collaborator

@centy, @ycv005, we've released version 4.2.0, which includes support for adaptive banners. Please check it out and feel free to file any issues you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants