Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade or remove vendored zlib? #75

Open
lalten opened this issue Apr 8, 2024 · 1 comment
Open

Upgrade or remove vendored zlib? #75

lalten opened this issue Apr 8, 2024 · 1 comment

Comments

@lalten
Copy link

lalten commented Apr 8, 2024

The vendored zlib which is used in zsync2 is based on zlib v1.2.1.1, which is now more than 20 years old.
Any considerations to either get rid of it or to upgrade to a more recent version?

Here's a patch file I generated by diffing the original zsync's sources with the zlib release they're based on: https://github.com/lalten/zsync/blob/76ba13e254d93d9949feffe3e4171fc49e5be488/c/zlib/zlib_1211.patch

And here is the same patch rebased to the latest zlib, 1.3.1
https://github.com/lalten/zsync/blob/76ba13e254d93d9949feffe3e4171fc49e5be488/c/zlib/zlib_131.patch

@probonopd
Copy link
Member

@TheAssassin wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants