Skip to content

Commit 953b84a

Browse files
committed
fixup! Keep i386 alive and add ARM builds
1 parent ef57f6b commit 953b84a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
strategy:
88
fail-fast: false
99
matrix:
10-
ARCH: [x86_64, aarch64, armhf]
10+
ARCH: [x86_64, i686, aarch64, armhf]
1111

1212
name: AppImage ${{ matrix.ARCH }}
1313
runs-on: ubuntu-20.04

ci/build-in-docker.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,18 @@ repo_root="$(readlink -f "$(dirname "${BASH_SOURCE[0]}")"/..)"
3535
uid="$(id -u)"
3636
image=zsync2-build:"$ARCH"
3737

38-
tty_args=()
39-
if [ -t 0 ]; then tty_args+=("-t"); fi
40-
4138
# building local image to "cache" installed dependencies for subsequent builds
4239
docker build \
4340
"${tty_args[@]}" \
44-
"$image" \
41+
-t "$image" \
4542
--build-arg ARCH="$ARCH" \
4643
--build-arg DOCKER_ARCH="$DOCKER_ARCH" \
4744
--build-arg CMAKE_ARCH="$CMAKE_ARCH" \
4845
"$repo_root"/ci
4946

47+
tty_args=()
48+
if [ -t 0 ]; then tty_args+=("-t"); fi
49+
5050
# mount workspace read-only, trying to make sure the build doesn't ever touch the source code files
5151
# of course, this only works reliably if you don't run this script from that directory
5252
# but it's still not the worst idea to do so

0 commit comments

Comments
 (0)