Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rollup v3 #224

Open
ghost91- opened this issue Oct 26, 2022 · 15 comments · May be fixed by #225
Open

Support for rollup v3 #224

ghost91- opened this issue Oct 26, 2022 · 15 comments · May be fixed by #225

Comments

@ghost91-
Copy link

This plugin currently is not compatible with rollup v3, because it requires rollup 2 as a peer dependency:

  "peerDependencies": {
    "rollup": "^2.63.0"
  },

From what I have seen, this plugin mostly seems to work with rollup v3. Probably some more checks need to be done, but possibly, not much more than adjusting the declaration of the peer dependency to something like

  "peerDependencies": {
    "rollup": "^2.63.0 || ^3.0.0"
  },

would be needed.

mathiasschopmans added a commit to mathiasschopmans/rollup-plugin-styles that referenced this issue Nov 3, 2022
@mathiasschopmans mathiasschopmans linked a pull request Nov 3, 2022 that will close this issue
@7nik
Copy link

7nik commented Dec 10, 2022

any ETA? It breaks auto-builds and annoys to do force installs of libs due to this issue.

@Anidetrix are you even OK?

@magnnus
Copy link

magnnus commented Jan 4, 2023

any progress?

@adanielyan
Copy link

I cannot update my directus because of this issue. Is there any workaround?

@hanorine
Copy link

hanorine commented Feb 6, 2023

I would also like to stress the need to add support for rollup v3. Is this package being maintained by anyone? Need to know so I can make decisions. If there is anything that I can do to get this across? are there any limitations for supporting v3? Thank you.

@hanorine
Copy link

hanorine commented Feb 6, 2023

Looks like @ironkinoko/rollup-plugin-styles is a fork of this repo with rollup v3 support.

https://www.npmjs.com/package/@ironkinoko/rollup-plugin-styles?activeTab=explore

"peerDependencies": {
    "rollup": "^2.63.0 || 3.x"
  },

@gregor-mueller
Copy link

Any response would be great! There is a PR ready (#225) but the Owner @Anidetrix does not seem active on GitHub. Maybe a maintainer like @felipecrs can have a look there and help all of us out! Would be really appreciated! 🙇

@cichyadam
Copy link

+1

@KenjiTakahashi
Copy link

Looks there was some movement recently on @Anidetrix account. Perhaps the guy is around after all ;-)?

eliot-akira added a commit to TangibleInc/tangible-roller that referenced this issue Apr 7, 2023
@entozoon
Copy link

+1

@me6iaton
Copy link

me6iaton commented Oct 25, 2023

Why
Because alternatives did not look good enough - they are either too basic, too buggy or poorly maintained.

@rhahne
Copy link

rhahne commented Mar 25, 2024

Has anyone found a good alternative in the meantime? It seems like multiple rollup plugins for styles are not working for rollup v4, what are you all using?

@hanorine
Copy link

I recently moved my solution to leverage "@dougalg/rollup-plugin-postcss"

  import postcss from '@dougalg/rollup-plugin-postcss';

  // in rollup config plugin section:
   postcss({
      extract: false,
      modules: true,
      use: ['sass'],
    })

@KenjiTakahashi
Copy link

https://github.com/plumelo/rollup-plugin-styler is updated, at least for now.

@dlsaldanas
Copy link

Has anyone found a good alternative in the meantime? It seems like multiple rollup plugins for styles are not working for rollup v4, what are you all using?

In our company we decided to move away from post-css, and avoid third parties as much as posible

@rhahne
Copy link

rhahne commented Mar 27, 2024

Thanks for your comments. To give an update on my side, we switched the plugin and now use https://github.com/egoist/rollup-plugin-postcss in combination with sass:

 postcss({
      use: [
        ['sass', {
          includePaths: ['./styles', 'node_modules'],
          implementation: sass,
        }]
      ],
      extract: 'styles.css',
    }),

Although this plugin also hasn't been updated in a while, it works on our side and doesn't show any warniing / error messages regarding peer-dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.