-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform(actions): create automated action to generate emoji.json
inline with unicode.org
#226
Comments
As continuation of #293 Would you like to keep the same json structure as it is rn? So we need to create a script that will parse https://unicode.org/Public/emoji/latest/emoji-sequences.txt into a json, right? Is this the json structure library is awaiting for?
Here's a
Currently i've manually downloaded this txt: https://unicode.org/Public/emoji/latest/emoji-sequences.txt and ran script for it. We can update the script later so it automatically downloads that file, then parses. I see an issue that unicode's I've attached raw |
Amazing, will circle back over the weekend. I don't mind changing the structure of the json file, we'll just release a major version which is a small price to pay if it means that we can keep up with the latest emoji standard |
@DanyloOliinykSSG I was planning on using a secondary data source https://cdn.jsdelivr.net/npm/emojibase-data@latest/en/data.json to obtain additional meta-data, like tags/alias the only limitation with both approaches is that when we release this new version the tag/aliases may differ. Some insights into An additional improvement is also adding a |
Hi @wax911 ! So you want to merge data from https://unicode.org/Public/emoji/latest/emoji-sequences.txt and https://cdn.jsdelivr.net/npm/emojibase-data@latest/en/data.json? Regarding the Anything i can help with? |
Hey @DanyloOliinykSSG would love a helping hand, I've created a branch feat/226-platform-actions-create-automated-action.. which has a script to generate a compliant The next few items we need to do is update the contract of IEmoji to match the new schema, I will release this change as a new major version update as the emoji data vastly differs. So to wrap it up here's the next few things we need to do to complete this task:
|
Wow, that's a lot of work being done @wax911 ! 😯😎
phew, that's cool 😌
ENV variable with the latest release version? I'm not sure how that "hook" should work.. i mean how to trigger automated PR for unicode emoji releases? Can it be reactive, or it's just like "check updates once in XXX days?" 🧐 Also regarding the And a sidenote/question: why do we need an interface for a model? Do you anticipate different implementation of it? AFAIK it's not common to have models under interfaces 🙄 But i'm a bit out of context of this repo, so sorry if that's a weird question 😄 |
I was thinking cron job to run every Sunday e.g.
But to your comment perhaps we don't need to pass in the version as we could just use
The current
Good question! Normally, models don’t require an interface, but in this case, it follows Dependency Inversion Principle (DIP) and is inspired by the Strategy Pattern. The library provides multiple serializer implementations (Moshi, Gson, Kotlinx Serialization, etc.), but the The goal is to keep the library modular and lightweight, allowing consumers to pick only what they need. The Strategy Pattern fits here since different serializer strategies (Gson, Moshi, Kotlinx) can be swapped without modifying the |
@DanyloOliinykSSG please review #321 when you have a moment, this takes care of the automation aspect of creating an update emoji-base alined |
Yup, reviewed it. I guess it's fine - the only thing is maybe we can test |
AniTrend Issue Guidelines
Before opening a new issue, please take a moment to review our community
guidelines to make the
contribution process easy and effective for everyone involved.
You may find an answer in already closed issues:
https://github.com/AniTrend/android-emojify/issues?q=is%3Aissue+is%3Aclosed
Feature Information
https://home.unicode.org/ often provides new Unicode versions, see: https://unicode.org/Public/emoji/ where we can find all the Unicode versions released. Ideally, we’d love to generate a
emoji.json
file based on the latest Unicode standard and make an automated PR for it.Solution Information
Fetch Unicode Emoji Test Data:
https://unicode.org/Public/emoji/latest/emoji-test.txt
.Fetch Emojibase Data:
https://cdn.jsdelivr.net/npm/emojibase-data@<latest_version>/en/data.json
.Process Emoji Data:
fully-qualified
emoji formatsSave to File:
emoji.json
).Proposed GitHub Workflow
To automate the process of generating and submitting a PR for
emoji.json
:Schedule Workflow:
Fetch and Compare Emoji Versions:
Generate Updated
emoji.json
:emoji.json
.Automate PR Creation:
emoji.json
.Notify Reviewers:
Example GitHub Action
Additional Context
TBA
The text was updated successfully, but these errors were encountered: