Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Code Style, Conventions #10

Open
crocsandcoffee opened this issue Nov 8, 2022 · 5 comments
Open

[FEAT]: Code Style, Conventions #10

crocsandcoffee opened this issue Nov 8, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@crocsandcoffee
Copy link
Member

Description

It was requested in #mastodon-client slack channel for documentation regarding code style and coding conventions.

This is just an "issue" to track that and for anyone to offer any input.

As a starting point I suggest we just use the default kotlin style guide for now, unless anyone feels strongly and wants to create a custom one that follows certain guidelines and can be included in the project and imported in workspaces.

Additional Information

No response

@crocsandcoffee crocsandcoffee added the enhancement New feature or request label Nov 8, 2022
@svenjacobs
Copy link

The project could enforce a code style with ktlint and Twitter's 😉 Compose Rules. Latter is really nice because it also catches common Compose errors / gotchas.

@bitPogo
Copy link

bitPogo commented Nov 9, 2022

Maybe spotless with ktlint is an option.

@bitPogo
Copy link

bitPogo commented Nov 9, 2022

Almost forgot - Danger to enforce some PR standards.

@hrules6872
Copy link

I know the default kotlin style guide says "Use four spaces for indentation" but I find it such an old fashioned formatting... is everyone agree not to change it to 2?

@svenjacobs
Copy link

Why not use tabs? Then everyone can individually decide how indentation is rendered? 🔥 (let the flame wars begin 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants