Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Use Unique key For import and var #314

Open
sshaw opened this issue Apr 21, 2019 · 1 comment
Open

Go: Use Unique key For import and var #314

sshaw opened this issue Apr 21, 2019 · 1 comment
Labels
seen PR was seen and initial feedback was given

Comments

@sshaw
Copy link
Contributor

sshaw commented Apr 21, 2019

Currently import and import( both use imp. Same with var. This is a bit annoying as these are used often and result in a prompt to pick the desired one.

I propose:

  1. var = var N
  2. var( = var ( N )

Or maybe:

  1. va = var N
  2. var = var ( N )

mnemonic: var results in a longer definition than va.

Same pattern for import.

Really the key for var ( N ) should support a list of vars as this is the common use case.

Interested? Thoughts? I can submit a PR.

@AndreaCrotti
Copy link
Owner

Uhm that's quite a funny syntax, I didn't know you could do that.
Anyway which one do you think it's more common @sshaw ?

I would be fine with var and var( for example I think.

@AndreaCrotti AndreaCrotti added the seen PR was seen and initial feedback was given label Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seen PR was seen and initial feedback was given
Projects
None yet
Development

No branches or pull requests

2 participants