Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid subscribing to all the possible subs in the root handler #56

Closed
AndreaCrotti opened this issue Sep 20, 2018 · 1 comment
Closed

Avoid subscribing to all the possible subs in the root handler #56

AndreaCrotti opened this issue Sep 20, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@AndreaCrotti
Copy link
Owner

If we subscribe to everything in root, it means that any change in one of the subscription would cause a re render of the whole page.
We should simply have components subscribe to the signals directly so we avoid this problem.
@AndreaCrotti AndreaCrotti added the bug Something isn't working label Sep 20, 2018
@AndreaCrotti
Copy link
Owner Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndreaCrotti