Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudy vs Partly Cloudy #60

Open
bergsm opened this issue Dec 2, 2020 · 2 comments
Open

Cloudy vs Partly Cloudy #60

bergsm opened this issue Dec 2, 2020 · 2 comments
Assignees

Comments

@bergsm
Copy link

bergsm commented Dec 2, 2020

Currently there is not distinguishing between cloudy and partly cloudy, the script uses the cloudy icon for any weather report with the word cloud in it, even if there are few clouds.

@vKnmnn
Copy link
Collaborator

vKnmnn commented Dec 3, 2020

could you compile a list of the other strings you get with "cloudy" in them? Please give an example what the 'weather report' looks like, so i get an idea how to fix this.

@vKnmnn vKnmnn self-assigned this Dec 3, 2020
@bergsm
Copy link
Author

bergsm commented Dec 8, 2020

Hey vKnmnn,

Thanks for your response! I went ahead and looked into openweathermap api a bit more, and discovered all of the possible condition codes that can be returned as well as a list of available icons provided by openweathermap. You can check out the list here. It may allow for easier development as well using the condition codes rather than parsing the text from the response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants