* Removed all print calls and replaced with warning or message when relevant

* Add Authors@R field instead if Author and Copyright fields as per feed-back.
* Add Steven Brandt as contributor as his article in Java World formed the basis of the XMl parser
* Add \value tag to utils.Rd
* Add single quote in Title and Description fields where required in DESCRPTION

Author: perNyfelt

DESCRIPTION

@@ -1,13 +1,16 @@
 Package: xmlr
-Version: 0.1.1
-Date: 2020-05-03
-Title: Read, Write and Work with XML Data
-Author: Per Nyfelt [aut, cre]
+Version: 0.1.2
+Date: 2020-05-06
+Title: Read, Write and Work with 'XML' Data
+Authors@R: c(
+    person("Per", "Nyfelt", email = "[email protected]", role = c("cre", "aut")),
+    person("Alipsa HB", email = "[email protected]", role = "cph"),
+    person("Steven", "Brandt", role = "ctb")
+    )
 Maintainer: Per Nyfelt <[email protected]>
-Copyright: Alipsa HB
 Depends: R (>= 3.1.0)
 Encoding: UTF-8
-Description: XML package for creating and reading and manipulating XML, with an object model based on Reference Classes.
+Description: 'XML' package for creating and reading and manipulating 'XML', with an object model based on 'Reference Classes'.
 License: MIT + file LICENSE
 URL: https://github.com/Alipsa/xmlr
 BugReports: https://github.com/Alipsa/xmlr/issues

NAMESPACE

@@ -7,8 +7,6 @@ export(Text)
 export(isRc)
 export(parse.xmlfile)
 export(parse.xmlstring)
-export(printp)
-export(printp0)
 export(xmlrToDataFrame)
 exportClasses(AbstractClass)
 exportClasses(Content)

R/Document.R

@@ -45,18 +45,18 @@ Document <- setRefClass(
     },
 
     getDocType = function() {
-      printp("Document$getDocType() not implemented")
+      warning("Document$getDocType() is not implemented")
     },
 
     setDocType = function(docType) {
-      printp("Document$setDocType(docType) not implemented")
+      warning("Document$setDocType(docType) not implemented")
     },
 
     toString = function() {
       if ("root" %in% names(content) & !is.null(content$root)) {
         return(paste0(content$root$toString()))
       }
-      print("Attempted toString on a rootless document; There is no root element for this document")
+      message("Attempted toString on a rootless document; There is no root element for this document")
       ""
     },
 

R/DomBuilder.R

@@ -14,30 +14,24 @@ DomBuilder <- setRefClass(
 
     startDocument = function() {
       "Event signalling parsing has begun"
-      #print("Start document")
       stack <<- Stack$new()
     },
 
     endDocument = function() {
       "Event signalling parsing has completed"
-      #print("End document")
       doc$setRootElement(root)
       stack <<- NULL
-      #printp("Parsing complete!")
     },
 
     startElement = function(name, attributes) {
       "start element event; @param name the element name, @param attributes a named list of attributes"
-      #printp("Start element", name)
       e <- Element$new(name)
-      #print(str(attributes))
       e$setAttributes(attributes)
       stack$push(e)
     },
 
     endElement = function(name) {
       "end element event; @param name the element name"
-      #printp("End element", name)
       current <- stack$peek()
       if (!stack$isEmpty()) {
         e <- stack$pop()
@@ -53,7 +47,6 @@ DomBuilder <- setRefClass(
     text = function(text) {
       "text event; @param text the character content of the Text node"
       if (nchar(trimws(text)) > 0) {
-        #printp0("Add text '", text, "'")
         stack$peek()$setText(text)
       }
     }

R/Element.R

@@ -26,7 +26,6 @@ Element <- setRefClass(
       if(!is.null(name)) {
         m_name <<- name
       }
-      #print(paste("Element created, name is", private$name))
     },
 
     addContent = function(content) {
@@ -61,9 +60,10 @@ Element <- setRefClass(
       return(NULL)
     },
 
-    cloneContent = function() {
-      printp("Element", "cloneContent()", "Not implemented, should return a list containing detached clones of this parent's content list")
-    },
+    #cloneContent = function() {
+    #  "should return a list containing detached clones of this parent's content list"
+    #  warning("Element", "cloneContent()", "Not implemented")
+    #},
 
     contentIndex = function(content) {
       "Find the position of the content in the contentList or -1 if not found"
@@ -185,7 +185,6 @@ Element <- setRefClass(
       "Return the first child element matching the name"
       for (content in contentList) {
         if ("Element" == class(content) & content$getName() == name) {
-          #print(paste("Found child element", content))
           return (content)
         }
       }

R/Parser.R

@@ -74,8 +74,6 @@ Parser <- setRefClass(
       db$startDocument()
 
       for (c in charVector) {
-        #printp0("  looking at: '", c, "'")
-
         # We need to map \r, \r\n, and \n to \n See XML spec section 2.11
         if (c == '\n' & eol) {
           eol <- FALSE

R/Stack.R

@@ -18,7 +18,6 @@ Stack <- setRefClass(
     },
 
     isEmpty = function() {
-      # printp("Stack size is", size)
       if (m_size == 0) {
         return(TRUE)
       } else {

R/utils.R

@@ -1,32 +1,18 @@
 #' Common utility functions
 
-#' @describeIn utils Simple combo of print and paste.
-#' @param ... all the stuff that should be printed
-#' @export
-printp <- function(...) {
-  print(paste(...))
-}
-
-#' @describeIn utils Simple combo of print and paste0.
-#' @param ... all the stuff that should be printed
-#' @export
-printp0 <- function(...) {
-  print(paste0(...))
-}
-
 #' @describeIn utils Check if the object is a reference class, similar to isS4().
 #' @param x the object to check
 #' @param clazz the name of the class e.g. "Element" for the Element class.
 #' Optional, if omitted it checks that the object is a reference class
+#' @return A boolean indicating whether the object \code{x} belongs to the class or not
 #' @export
 isRc <- function(x, clazz = "refClass") {
   is(x, clazz)
 }
 
-
 # internal
 notImplemented <- function(className, methodName, ...) {
-  print(paste(paste0(className, "$", methodName), "Not implemented,", ...))
+  warning(paste(paste0(className, "$", methodName), "Not implemented,", ...))
 }
 
 # internal

cran-comments.md

@@ -1,4 +1,12 @@
-## Resubmission
+## Resubmission 2
+This is a resubmission. In this version I have:
+* Removed all print calls and replaced with warning or message when relevant
+* Add Authors@R field instead if Author and Copyright fields as per feed-back.
+* Add Steven Brandt as contributor as his article in Java World formed the basis of the XMl parser 
+* Add \value tag to utils.Rd
+* Add single quote in Title and Description fields where required in DESCRPTION 
+
+## Resubmission 1
 This is a resubmission. In this version I have:
 * Fixed the LICENSE to adhere to the standard template format for MIT