Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "unknown" endRow and endColumn variables #3

Open
perNyfelt opened this issue Apr 12, 2022 · 1 comment
Open

support "unknown" endRow and endColumn variables #3

perNyfelt opened this issue Apr 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@perNyfelt
Copy link
Member

From https://github.com/AntoineKMS (extracted from issue #1 )
I am not sure If I should post it here, but I have another very small issue with this library. It's about the endRow, endColumn variables.
Would it be possible to have a default value that would just take as many rows and columns as there are in the sheet ?

It is very good to be able to tweak those parameters for when we only want certains parts of the sheet, but I think it would be good to have an option/ a default parameter to just take the whole sheet.

Thank you.

@perNyfelt
Copy link
Member Author

I'll look at it. I think this is reasonably well supported in Apache POI for Excel but there is nothing like this for SODS (Libre/Open Office) so I'll have to do some manual probing for that which might be slow. Maybe a magical constant e.g. setting the endRow and endColumn to -1 or similar would be a decent way to support this.

@perNyfelt perNyfelt added the enhancement New feature or request label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant