-
Notifications
You must be signed in to change notification settings - Fork 775
WSS-stream for ipeye #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WSS-stream for ipeye #1870
Conversation
rollback go.mod go.sum
pkg/ipeye/ipeye.go
Outdated
|
|
||
| // probe waits for init with avcC and extracts SPS/PPS | ||
| func (p *Producer) probe() error { | ||
| log := app.GetLogger("ipeye") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't import app in pkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What logger should I use then? zerolog? Or is it better to delete logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current architecture does not allow using logs in pkg. This has not been worked out yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, deleted all logs
pkg/ipeye/ipeye.go
Outdated
| } | ||
|
|
||
| // RTP packetizer | ||
| h264Pay := &codecs.H264Payloader{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary to use H264Payloader in clients
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, removed this
pkg/ipeye/ipeye.go
Outdated
| } | ||
|
|
||
| // convert AVCC -> AnnexB | ||
| annexbData := annexb.DecodeAVCC(mdatData, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave AVCC for packet payload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
fixes from review
pkg/ipeye/ipeye.go
Outdated
| if dur == 0 { | ||
| dur = p.clockRate / 25 // fallback | ||
| } | ||
| // RTP TS для этого sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments must be in English
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
comments translated
|
This code doesn't work for me. I tried to connect to the demo stream on the website. The packets are processed, but there is no image. |
|
I found a problem with launching in go2rtc player, but it works in vlc and frigate in web console: Can you suggest what the problem might be? |
|
The stream didn't work for me anywhere at all. |
#1678
Added converter for ipeye wss stream