-
Notifications
You must be signed in to change notification settings - Fork 775
Update README #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update README #1720
Conversation
|
|
@AlexxIT, thanks a lot for looking into it.
|
@AlexxIT I reverted this. I believe all your concerns are sorted now. Also, I fixed all conflicts caused by #1773. And additionally, I refactored all occurrences of 2-way and two way terminology into two-way. Also refactored Add-on into add-on. |
|
@ehn maybe you can help review this PR too. :) |
Looks good to me. :) |
|
@AlexxIT I updated the PR description to highlight everything this PR does. I hope that helps reviewing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
|
@AlexxIT I don’t want to bother you, but it might be a good time to take a look at this PR. It improves the appearance and consistency of the README, so the sooner it’s merged, the better for new readers. |
@AlexxIT, I went through the README and made some updates:
Update config dir example to. EDIT: reverted this part./homeassistantwhich is what more modern add-ons will use (like Frigate 0.16)I hope you like it.