fix: Unpairing HomeKit streams #1658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexxIT
reviewed
Sep 30, 2025
|
|
||
| "github.com/AlexxIT/go2rtc/internal/api" | ||
| "github.com/AlexxIT/go2rtc/internal/app" | ||
| "github.com/AlexxIT/go2rtc/pkg/hap" |
There was a problem hiding this comment.
I don't like this dependency in this module. The streams module does not need to know about the existence of any particular source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my tests with camera.ui, I encountered the following issue:
After I paired a HomeKit camera using go2rtc, and later deleted it through the API (without unpairing it), I was no longer able to unpair the camera. In HomeKit Discovery, the camera was shown as paired, without the possibility to unpair it.
Refactoring and code simplification (due to circular dependencies)
findHomeKitURLsandfindHomeKitURLfunctions frominternal/homekit/api.goandinternal/homekit/homekit.go, respectively, and replaced their usage with the newstreams.FindPrefixURLsandstreams.FindPrefixURLfunctions.FindPrefixURLandFindPrefixURLsfunctions tointernal/streams/helpers.goto handle URL finding logic based on a prefix.Dependency updates:
happackage tointernal/streams/api.gofor handling HomeKit unpairing.Enhancements to stream deletion:
apiStreamsfunction ininternal/streams/api.goto unpair HomeKit streams before deletion.