Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for #killsignal and #killtimeout with exec:..#backchannel=1 #1555

Open
jbayart opened this issue Jan 18, 2025 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@jbayart
Copy link

jbayart commented Jan 18, 2025

Hi,
I'm using an exec command with #backchannel=1 parameter in the context of a two-way audio doorbell. To add a bit more context, I'm following more or less the setup described in this thread blakeblackshear/frigate#11924 (comment).
When closing the go2rtc stream, my exec command receive a SIGKILL signal and terminates immediatly without the opportunity to close properly sub commands. So I would like to use killsignal parameter to customize kill signal when stream is shut down, like specified here https://github.com/AlexxIT/go2rtc?tab=readme-ov-file#source-exec. Basically I'm having the same issue than #1193 but with a command using backchannel context.

Unfortunelty, from what I've experienced with go2rtc and what I've seen in the code, it seems like these parameters are not taken into account when exec command is used with backchannel, so I think it would be a great addition.

@AlexxIT AlexxIT added the enhancement New feature or request label Jan 18, 2025
@AlexxIT AlexxIT self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants