Problem:

I've been having fun with the refinebio python client. 🎉 (Not sure if you guys are looking for people to test this yet but too late).

I ran this kinda thing and hoped to download and extract data to a folder called data:

os.mkdir("data", mode = 0o777)

pyrefinebio.create_token(agree_to_terms=True, save_token=False)

pyrefinebio.download_dataset(
    "data/dataset.zip",
    "[email protected]",
    experiments=["SRP070849"],
    extract=True
)

Based on this description from the quickstart

extract can be used to choose whether the downloaded zip file should be automatically extracted. It will automatically extract to the same location that you passed in as path. So if path is a zip file: ./path/to/dataset.zip it will be extracted to the dir ./path/to/dataset/, if path is a dir: ./path/to/dir/ it will be extracted to ./path/to/dir/[generated-file-name]/. By default, extract is False.

I expected to find the files inside my data directory if I used extract=True.

But instead my files did not go into my data directory, only the original zip file went there.

Solution (I think):

I think this needs to use the extract_dir based on the from the path that's passed in. But I'm not 100% sure.