Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nextflow container image #169

Open
arkid15r opened this issue May 24, 2022 · 1 comment
Open

Update Nextflow container image #169

arkid15r opened this issue May 24, 2022 · 1 comment

Comments

@arkid15r
Copy link
Contributor

Address the concern regarding:

I see that you changed this back, which may be fine. I realized that I needed to change the location of the aws cli in nextflow settings, which I had neglected to do, and might be having some effect, though I don't think this is the main problem. I worry some about having two version of the aws cli, one of which is presumably older and may be missing features?

https://github.com/AlexsLemonade/scpca-nf/blob/ef585fd1ab13ef24920a39579e5fb61c2c7a263c/config/profile_awsbatch.config#L5

One note is that according to the nextflow docs, the aws cli is mounted into the docker image in kind of a strange way, which could also cause trouble: https://www.nextflow.io/docs/latest/aws.html#aws-cli

https://github.com/AlexsLemonade/alsf-scpca/pull/168/files#diff-36dc947c782c6593c13829bb3ffaaf2422f2df60bcab504861f29a0de056aca1R36

@arkid15r arkid15r self-assigned this May 24, 2022
@arkid15r
Copy link
Contributor Author

Looking at the install location, it appears that the binary gets installed in /usr/local/aws-cli with symlinks to /usr/local/bin. Because of the way nextflow mounts the aws directory, we might be able to get away with making a link from /usr/local/aws-cli/aws to /usr/local/aws-cli/bin/aws. This will result in nextflow mounting all of /usr/local/aws-cli which should not clobber anything. (If we were to specify the path to nextflow as /usr/local/bin/aws it would try to mount all of /usr/local in the docker images, which would probably be bad).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant