Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new version of libfobos #1572

Open
yurivict opened this issue Jan 23, 2025 · 1 comment
Open

Support for new version of libfobos #1572

yurivict opened this issue Jan 23, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@yurivict
Copy link

yurivict commented Jan 23, 2025

Hardware
n/a

Software

  • Operating System: FreeBSD 14.2
  • SDR++: 20250105

Bug Description

In file included from /usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/source_modules/fobossdr_source/src/main.cpp:5:
In file included from /usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/core/src/signal_path/signal_path.h:2:
In file included from /usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/core/src/signal_path/iq_frontend.h:3:
/usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/core/src/signal_path/../dsp/buffer/reshaper.h:61:13: warning: 'run' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   61 |         int run() {
      |             ^
/usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/core/src/signal_path/iq_frontend.h:79:43: note: in instantiation of template class 'dsp::buffer::Reshaper<dsp::complex_t>' requested here
   79 |     dsp::buffer::Reshaper<dsp::complex_t> reshape;
      |                                           ^
/usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/core/src/signal_path/../dsp/channel/../block.h:64:21: note: overridden virtual function is here
   64 |         virtual int run() = 0;
      |                     ^
/usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/source_modules/fobossdr_source/src/main.cpp:194:9: error: no matching function for call to 'fobos_rx_close'
  194 |         fobos_rx_close(dev);
      |         ^~~~~~~~~~~~~~
/usr/local/include/fobos.h:55:26: note: candidate function not viable: requires 2 arguments, but 1 was provided
   55 | API_EXPORT int CALL_CONV fobos_rx_close(struct fobos_dev_t * dev, int do_reset);
      |                          ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/ports/comms/sdr++/work/SDRPlusPlus-ea3675d/source_modules/fobossdr_source/src/main.cpp:343:9: error: no matching function for call to 'fobos_rx_close'
  343 |         fobos_rx_close(_this->openDev);
      |         ^~~~~~~~~~~~~~
/usr/local/include/fobos.h:55:26: note: candidate function not viable: requires 2 arguments, but 1 was provided
   55 | API_EXPORT int CALL_CONV fobos_rx_close(struct fobos_dev_t * dev, int do_reset);
      |                          ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 2 errors generated.

Steps To Reproduce
build

@yurivict yurivict added the bug Something isn't working label Jan 23, 2025
@AlexandreRouma AlexandreRouma removed the bug Something isn't working label Jan 26, 2025
@AlexandreRouma
Copy link
Owner

Not a bug, just a new major update to libfobos which is incompatible with the last one.

@AlexandreRouma AlexandreRouma changed the title Build fails with libfobos-2.3.2 Support for new version of libfobos Jan 26, 2025
@AlexandreRouma AlexandreRouma added the enhancement New feature or request label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants