Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct gs: and gcs: file protocols for name scripts #60

Closed
jameshalgren opened this issue May 26, 2023 · 1 comment · Fixed by #64
Closed

Correct gs: and gcs: file protocols for name scripts #60

jameshalgren opened this issue May 26, 2023 · 1 comment · Fixed by #64
Assignees

Comments

@jameshalgren
Copy link
Contributor

jameshalgren commented May 26, 2023

Suggest the following correction (items #5 and #6) to allow for proper downloading:

urlbasedict = {
    0: "",
    1: "https://nomads.ncep.noaa.gov/pub/data/nccf/com/nwm/prod/",
    # TODO The post-processed data will need its own name generator, such as
    # we have made for the retrospective data.
    # 2: "https://nomads.ncep.noaa.gov/pub/data/nccf/com/nwm/post-processed/WMS/",
    3: "https://storage.googleapis.com/national-water-model/",
    4: "https://storage.cloud.google.com/national-water-model/",
    5: "gs://national-water-model/",
    6: "gcs://national-water-model/",
    # TODO: add Amazon output??
    # 7: amazon s3 operational output
    # 8: amazon https operational output
}

(The todo associated with #2 and #7 is for another issue.... link forthcoming)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants