feat: add case transform #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-case-transform
branch
from
2c14ff1 to
4df98da
Compare
Claudenw
previously requested changes
Feb 25, 2025
| return caseValue; | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Should this return a null or should it throw
- a NPE on null argument and
- an
IllegalArgumentExceptionif the string is not found, like the enum.valueOf() does?
There was a problem hiding this comment.
Done, went with IllegalArgumentException.
Comment on lines
124
to
127
| caseTransformFunc = String::toLowerCase; | ||
| break; | ||
| case UPPER: | ||
| caseTransformFunc = String::toUpperCase; |
There was a problem hiding this comment.
These case changes are local specific. We should use toLowerCase(Locale.ROOT) and toUpperCase(Locale.ROOT).
see javadoc
There was a problem hiding this comment.
Done, added the root locale.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-case-transform
branch
from
4df98da to
c3d636c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.