Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet-app provides end-users an exit button on offers that have exit: { waived: null } in the proposal #119

Open
WietzeSlagman opened this issue Aug 22, 2023 · 0 comments
Labels
bug Something isn't working needs-design

Comments

@WietzeSlagman
Copy link

Describe the bug

Offers can have several exit clauses defined for them, one of them being waived meaning that only the creating smart-contract can exit this created offer. Currently the wallet-app displays an exit button for these offers and attempts to create an exit offer transaction, which fails.

To Reproduce

Steps to reproduce the behavior:

  1. Create a long-living offer which has exit: { waived: null } in the proposal
  2. navigate to wallet.agoric.app
  3. On the created offer press the exit button
  4. See transaction popping upon Keplr
  5. Pressing approve on the transaction creates an error on-chain

Expected behavior

Expect any offer that has the exit: { waived: null } in the proposal to not have a clickable exit button in the wallet-app frontend

Platform Environment

Additional context

Screenshots

image image image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-design
Projects
None yet
Development

No branches or pull requests

3 participants