Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fusdc: bootstrap tx observability coverage #10623

Open
0xpatrickdev opened this issue Dec 4, 2024 · 2 comments · May be fixed by #10963
Open

fusdc: bootstrap tx observability coverage #10623

0xpatrickdev opened this issue Dec 4, 2024 · 2 comments · May be fixed by #10963
Assignees
@samsiegart
Labels
enhancement New feature or request
Milestone
FU4: UI integration

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Dec 4, 2024 •
edited by turadg
Loading

What is the Problem Being Solved?

As a FUSDC stakeholder, I want to observe a TX lifecycle. I need to know if my transaction succeeded or failed and track progress along the way.

Description of the Design

  • TxStatus updates are covered in boot tests

    • Advancing -> Advanced -> Disbursed
    • Observed -> Forwarded
    • Advancing -> AdvanceFailed -> Forwarded

  • PoolMetrics updates are covered in boots

    • e.g. do we know the pool / LPs were repaid? was the borrow returned?

  • console logging

    • do we have sufficient trace() calls in Advancer, Settler, EventFeed, and StatusManager? We don't need to replicate all vstorage calls - as those can be retrieved - but consider ensuring each exo has some traces that will assist with future debugging.

Security Considerations

Scaling Considerations

Test Plan

Check the test coverage of how we update states.

Verify logging is sufficient for tracing

Upgrade Considerations
@0xpatrickdev 0xpatrickdev added the enhancement New feature or request label Dec 4, 2024
@0xpatrickdev 0xpatrickdev mentioned this issue Dec 4, 2024
Closed
@dckc dckc self-assigned this Dec 5, 2024
@dckc
Copy link
Member

dckc commented Dec 13, 2024

thinking out loud about the scope / design here... we seem to have distinct stories:

  • "As a node operator, I want to see stuff in console logs..."
    • how much is enough? hm.
  • "As someone trying to get an advance, I want to get status updates in my web user agent."
  • "As a liquidity provider, I want to know whether an advance settled back into the pool."

@turadg turadg assigned turadg and unassigned dckc Dec 18, 2024
@turadg turadg added this to the FU4: UI integration milestone Dec 18, 2024
@turadg turadg assigned dckc and unassigned turadg Jan 7, 2025
@LuqiPan LuqiPan unassigned dckc Jan 7, 2025
@LuqiPan
Copy link
Contributor

LuqiPan commented Jan 7, 2025

Unassigned this ticket for now, will find an owner in the next sprint

@samsiegart samsiegart mentioned this issue Jan 28, 2025
Closed
@samsiegart samsiegart linked a pull request Feb 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsiegart samsiegart

Labels
enhancement New feature or request
Projects
None yet
Milestone
FU4: UI integration
Development

Successfully merging a pull request may close this issue.

test(fast-usdc): multichain test for forward Agoric/agoric-sdk
5 participants
@turadg @dckc @LuqiPan @samsiegart @0xpatrickdev