[PW-8369] Type mismatch between NotificationEntity and ProcessNotificationHandler::markAsProcessing()

[timkoopmans50]

Describe the bug
Type error.

Versions
Shopware version: 6.4.17.2
Plugin version: 3.11.0

To Reproduce
Steps to reproduce the behavior:

1. Create a situation where the $merchantReference will be null.
2. Task will now fail on a typerror.

Expected behavior
The merchantReference should either be nullable throughout the whole application or always be a string.

CODE SNIPPETS:

This :
https://github.com/Adyen/adyen-shopware6/blob/3.11.0/src/Entity/Notification/NotificationEntity.php#L51
https://github.com/Adyen/adyen-shopware6/blob/3.11.0/src/Entity/Notification/NotificationEntity.php#L153

Does not match types with this: (NULL would result in type error)
https://github.com/Adyen/adyen-shopware6/blob/3.11.0/src/ScheduledTask/ProcessNotificationsHandler.php#L382

[timkoopmans50]

Please note that if you encounter this condition your whole task manager will not function anymore, which for big webshops results in major financial damage.

[candemiralp]

Hello @timkoopmans50,

Thank you for raising this issue. You are right, that TypeError most probably won't be caught. We created an internal ticket to investigate and solve this issue. We will update you when it is done.

Best Regards,
Can